Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Argo-CD from 7.2.1 to 7.3.2 #33

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Conversation

greut
Copy link
Contributor

@greut greut commented Jun 27, 2024

This means we can enable prometheus by default without having to worry about the CRDs being there. argoproj/argo-helm#2791

Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
@greut greut requested a review from iDmple as a code owner June 27, 2024 07:41
Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
@greut
Copy link
Contributor Author

greut commented Jun 27, 2024

@iDmple a step seems to be missing from the GHA.

@greut greut mentioned this pull request Jun 28, 2024
@iDmple
Copy link
Contributor

iDmple commented Jun 28, 2024

Whoops, done.

@greut
Copy link
Contributor Author

greut commented Jun 28, 2024

well well well. Better not piggypacking on other's PR it seems.

Screenshot 2024-06-28 at 13-48-13 chore bump Argo-CD from 7 2 1 to 7 3 2 by greut Pull Request CHORUS-TRE_chorus-tre

@iDmple
Copy link
Contributor

iDmple commented Jun 28, 2024

@greut you can't approve it?

@greut
Copy link
Contributor Author

greut commented Jun 28, 2024

@greut you can't approve it?

I see what the screenshot shows.

@iDmple
Copy link
Contributor

iDmple commented Jun 28, 2024

I removed this requirement, we need more people to review and fast for it to work.

@iDmple iDmple merged commit 6ad6796 into master Jun 28, 2024
1 check passed
@iDmple iDmple deleted the chore/argo-cd-7.3.2 branch June 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants